Conversation
3Hren
force-pushed
the
feat/route-operator
branch
4 times, most recently
from
191fadc to
b7ede17
Compare
3Hren
force-pushed
the
feat/route-operator
branch
4 times, most recently
from
d536906 to
0c425ee
Compare
sakateka
reviewed
May 4, 2026
sakateka
reviewed
May 4, 2026
sakateka
reviewed
May 4, 2026
sakateka
reviewed
May 4, 2026
3Hren
force-pushed
the
feat/route-operator
branch
2 times, most recently
from
45edfee to
a40d502
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
sakateka
approved these changes
May 4, 2026
saushew
reviewed
May 4, 2026
| } | ||
|
|
||
| actuator := NewFanOutActuator( | ||
| actuator := operator.NewFanOutActuator[*StageConfig]( |
| hardwareSlice = append(hardwareSlice, entry.HardwareRoute) | ||
| stats.HardwareRoutes++ | ||
| } | ||
| key.Insert(idx) |
Collaborator
There was a problem hiding this comment.
I understand that it's highly unlikely to overflow here in a common case. However, in an age of virtualisation, it is not obvious that we will not exceed the bitset.TinyBitset{} limit here. I'd suggest to implement the TryInsert method
| // and snapshot source. | ||
| func NewReconciler( | ||
| actuator Actuator, | ||
| snapshot SnapshotFunc, |
Collaborator
There was a problem hiding this comment.
I'd expect to see here the SnapshotProvider interface, not the function callback.
|
|
||
| // hardwareKey is a comparable form of a hardware route used to | ||
| // deduplicate AddRoute calls. | ||
| type hardwareKey struct { |
Collaborator
There was a problem hiding this comment.
This type duplicates the agents/yanet-route-operator/internal/discovery/neigh.HardwareRoute, and I predict that this will happen again in the other places. It's worth putting it in it's own package in common/go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.